Summary
This updates NCCL_HAS_ONE_SIDED_API to require NCCL_HAS_SYMMEM_DEVICE_SUPPORT, matching the existing guard pattern used for NCCL device-side support.
NCCL_HAS_SYMMEM_DEVICE_SUPPORT is not enabled for ROCm builds because nccl_device.h is excluded there. Without this additional guard, ROCm release branches can still compile one-sided NCCL paths that reference device-side support such as NCCLDevCommManager, causing build failures.
A related guard already exists from #186794; this extends the same protection to the one-sided API path after it caused issues on another ROCm branch.
Testing
- Verified the merge conflict is resolved.
- Verified
nccl_dev_cap.hpphas no conflict markers. - Verified
git diff --checkpasses for the changed file.
Pull Request resolved: #186888
Approved by: https://github.com/jeffdaily
SOCIAL SHARE CARD GENERATOR